feat: enforce mypy type checking across all source files#335
Open
Hweinstock wants to merge 1 commit intoaws:mainfrom
Open
feat: enforce mypy type checking across all source files#335Hweinstock wants to merge 1 commit intoaws:mainfrom
Hweinstock wants to merge 1 commit intoaws:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage ? 90.85%
=======================================
Files ? 42
Lines ? 4048
Branches ? 624
=======================================
Hits ? 3678
Misses ? 203
Partials ? 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e1f6ca0 to
a132fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #167
Description of changes:
Problem
There is no static analysis run to determine type mismatches to catch "obvious" bugs/errors. Additionally, the SDK has a
mypyconfig and apy.typedmarker butmypyis never run — not in CI, not in pre-commit. There are 211 type errors across 21 source files.mypyappears to be a standard already used by other teams and projects. Ex. strands-agents already enforcesmypy.Solution
uv run mypy src/to the CI lint job.# type: ignore[error-code]suppression.Significant
# type: ignoredirectives remain for issues that can't be fixed without logic changes (boto3 returns Any, strands type mismatches, TypedDict method limitations). These can be fixed as a follow-up, but carry risks for code that is not covered by integration tests.Testing
uv run mypy src/.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.