telemetry(auth): Enable load telemetry for Toolkit login webview #8100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Toolkit login webview throws an error when calling
setUiReady()
becauseloadMetadata
is undefined:This occurs because
supportsLoadTelemetry
defaults to false in the baseVueWebview
class, preventing the initialization ofloadMetadata
during webview setup. WithoutloadMetadata
, the webview cannot track load timing or emit load telemetry.Solution
Added one line to enable load telemetry in
ToolkitLoginWebview
.This flag was originally introduced in e7b7307 to track Amazon Q webview load times and failures. We're now extending this functionality to the Toolkit login webview for consistent telemetry across both implementations.
Before fix:
Toolkit login webview error showing loadMetadata undefined. This occurs because
supportsLoadTelemetry
defaults to false in the baseVueWebview
class, preventing the initialization ofloadMetadata
during webview setup. WithoutloadMetadata
, the webview cannot track load timing or emit load telemetry. The error happens here when trying to calculate duration:After fix:
Toolkit login webview successfully loading with duration metrics.
feature/x
branches will not be squash-merged at release time.