Skip to content

fix(explorer): Refresh s3 node on profile switch (#7401, #7665) #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(explorer): Refresh s3 node on profile switch (#7401, #7665) #7932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/shared/awsClientBuilderV3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,12 @@ export class AWSClientBuilderV3 {

private keyAwsService<C extends AwsClient>(serviceOptions: AwsServiceOptions<C>): string {
// Serializing certain objects in the args allows us to detect when nested objects change (ex. new retry strategy, endpoints)
const profileId = this.context.getCredentialProfileName()
return [
String(serviceOptions.serviceClient),
JSON.stringify(serviceOptions.clientOptions),
serviceOptions.region,
profileId,
serviceOptions.userAgent ? '1' : '0',
serviceOptions.settings ? JSON.stringify(serviceOptions.settings.get('endpoints', {})) : '',
].join(':')
Expand Down
4 changes: 4 additions & 0 deletions packages/toolkit/.changes/next-release/Bug Fix-6318dec2-72a8-4464-ab84-e51913624f8c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "S3 node in explorer is not refreshed on profile change"
}