Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(amazonq): refactor shortAnswer to accommodate API changes #6747

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor(amazonq): refactor shortAnswer to accommodate API changes #6747

wants to merge 4 commits into from
+133 −43

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented Mar 7, 2025 •
edited
Loading

please don't merge yet, thank you!

Problem

  • API has been refactored with new fields
  • shortAnswer will eventually be deprecated
  • new field jobSummary which has a summary about tests that were generated

Solution

  • implemented new field: packageInfoList and its subfields
  • display test summary in chat

TODO:

  • integrate new API fields: buildCommand (once build exec is released), packageSummary, fileSummary, etc
  • remove all unused instances of shortAnswer
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

chungjac added 2 commits March 6, 2025 16:31
@chungjac
refactor shortAnswer
03c59f1 
just testgen related objects

extractShortAnswer:

use packageInfoList
@chungjac
TODO
457c09b
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@chungjac chungjac marked this pull request as ready for review March 7, 2025 19:08
@chungjac chungjac requested review from a team as code owners March 7, 2025 19:08
laileni-aws
laileni-aws reviewed Mar 7, 2025
View reviewed changes
packages/core/src/codewhisperer/models/model.ts
@@ -1175,6 +1175,7 @@ export interface ShortAnswerReference {
}
}

// TODO: remove ShortAnswer because it will be deprecated
export interface ShortAnswer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this ShortAnswer being used any where in the project apart from build and execute in public master branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being used anywhere else. I will eventually delete this after I do the shortAnswer refactoring for build exec

laileni-aws
laileni-aws approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you do E2E testing in these 3 scenarios?

  • Success(both ACCEPTED/REJECTED)
  • Failed
  • Cancelled

@chungjac
Copy link
Contributor Author

chungjac commented Mar 7, 2025

Completed testing for success, failed, and cancelled scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laileni-aws laileni-aws laileni-aws approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chungjac @laileni-aws