Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(flaky): skip CodeCatalyst Inactivity Message test. #6473

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Jan 30, 2025

Problem

Resolving #6213

Solution

  • skip the test.
  • This is low risk because:
    • the test above it tests very similar behavior.
    • a missing warning message not appearing is low risk.
    • codecatalyst users is aparently 0 anyway.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock
Copy link
Contributor Author

Hweinstock commented Jan 30, 2025

/runIntegrationTests

@Hweinstock Hweinstock changed the title test(flaky): increase valid duration for inactivity message to appear test(flaky): skip CodeCatalyst Inactivity Message test. Jan 31, 2025
@Hweinstock Hweinstock marked this pull request as ready for review January 31, 2025 20:44
@Hweinstock Hweinstock requested a review from a team as a code owner January 31, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant