Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): pre-fetch next recommendations for inline completions #6419

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented Jan 23, 2025

Problem

To support complex recommendations broken into multiple chunks, we need the ability to immediately show user next recommendation when they accept previous one

Solution

pre-fetch next recommendation predicting user accept first recommendation when showing them to user, and if user did accept first recommendation, immediately show next recommendation


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@@ -133,6 +133,7 @@ export class DefaultCodeWhispererClient {
}

async createUserSdkClient(maxRetries?: number): Promise<CodeWhispererUserClient> {
const session = CodeWhispererSessionState.instance.getSession()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm, found it

@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review January 31, 2025 23:25
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners January 31, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants