-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appbuilder): Update support for enVar in the webview #6413
base: master
Are you sure you want to change the base?
Conversation
|
@@ -0,0 +1,4 @@ | |||
{ | |||
"type": "Feature", | |||
"description": "Update support for enVar in the webview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Update support for enVar in the webview" | |
"description": "Lambda: Support for environment variables in the editor webview." |
if (this.resourceData.environment?.Variables !== undefined) { | ||
this.environmentVariables.value = JSON.stringify( | ||
this.resourceData.environment?.Variables | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty deeply nested, does it really depend on if (this.launchConfig.lambda)
? If not, can you pull it out a little, e.g. after if (this.launchConfig && this.resourceData) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending comments
Problem
Update support for enVar in the webview
feature/x
branches will not be squash-merged at release time.