Skip to content

fix(appbuilder): Update support for enVar in the webview #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2025
Merged

fix(appbuilder): Update support for enVar in the webview #6413

merged 3 commits into from
Feb 6, 2025

Conversation

jonife
Copy link
Contributor

@jonife jonife commented Jan 22, 2025

Problem

Update support for enVar in the webview

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonife jonife requested a review from a team as a code owner January 22, 2025 19:58
@github-actions GitHub Actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Vandita2020
Vandita2020 reviewed Jan 22, 2025
View reviewed changes
hayemaxi
hayemaxi reviewed Jan 23, 2025
View reviewed changes
hayemaxi
hayemaxi reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending comments

@hayemaxi hayemaxi merged commit 02d21a2 into aws:master Feb 6, 2025
25 of 26 checks passed
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@jonife @s7ab059789
fix(appbuilder): Update support for enVar in the webview (aws#6413)
c1f86ad 
## Problem
Update support for enVar in the webview

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Vandita2020 Vandita2020 Vandita2020 approved these changes

@hayemaxi hayemaxi hayemaxi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonife @Vandita2020 @hayemaxi