ci: editing PR description re-triggers all GitHub Actions #6274
+9
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
changed the title
justinmk3
changed the title
justinmk3
changed the title
justinmk3
commented
Dec 18, 2024
| @@ -130,6 +130,7 @@ Invalid pull request title: \`${title}\` | |||
| * scope: lowercase, <30 chars | |||
| * subject: must be <100 chars | |||
| * documentation: https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#pull-request-title | |||
| * Hint: *close and re-open the PR* to re-trigger CI (after fixing the PR title). | |||
justinmk3
changed the title
Problem: Since 6dcbfc7, the `lint-commits` job runs whenever the PR *description* is edited, which then re-runs all the other GHA jobs. This is because it listens to the `edited` event. Solution: There is no way to avoid rerunning all the CI jobs if they are dependent on `lint-commits`. Instead, revert 6dcbfc7 and document that re-opening the PR will force CI to re-run, if needed, after fixing a PR title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Since 6dcbfc7, the
lint-commitsjob runs whenever the PR description is edited, which then re-runs all the other GHA jobs. This is because it listens to theeditedevent, which triggers whenever the PR is edited in any way (very noisy).Solution:
There is no way to avoid rerunning all the CI jobs if they are dependent on
lint-commits. Instead, revert 6dcbfc7 and document that re-opening the PR will force CI to re-run, if needed, after fixing a PR title.feature/xbranches will not be squash-merged at release time.