Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(core): merge all package test reports #6261
test(core): merge all package test reports #6261
Changes from 14 commits
0b2aed9
081c031
5ef73cf
dfe2892
5273b20
5b6e145
adf5ca6
4e5655f
bb0bf30
b7e94e0
9d89d5b
155f4c5
d03a757
924b90e
5d3ade7
9a6f7b7
28384ad
a5f44d8
e7d26cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on a local test of this command:
I suspect the above
;
may not correctly pipe all the output fromnpm test
torun_and_report
as intended.To confirm that the piping to
run_and_report
is still working correctly, can you try temporarily changing this search patter to something that always outputs, like:then CI should fail.
If it doesn't, we can fix the issue by changing the pipeline to something like (note: whitespace near the braces is required):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and that was indeed the case. I've switched to your suggestion and it seems to work as expected