Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(settings): make isPromptEnabled non-async #6255

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Dec 16, 2024

Problem

There is no real reason this needs to be async. It is also now inconsistent with isExperimentEnabled.

Solution

Make non-async and add logged error if the promise rejects.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock marked this pull request as ready for review December 17, 2024 15:52
@Hweinstock Hweinstock requested review from a team as code owners December 17, 2024 15:52
@justinmk3 justinmk3 merged commit 04a5b68 into aws:master Dec 17, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants