-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(perf): increase cpu threshold #6249
Conversation
0b791ae
to
21b06f1
Compare
21b06f1
to
e4ee570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point are we even getting value from the performance tests? It feels like we're just going to increase the number indefinitely
I don't think the system stat thresholds are giving us much insight because of their flakiness. The thresholds on |
Hmmm, looks like these tests are very flaky aws-toolkit-vscode/packages/amazonq/test/unit/codewhisperer/util/crossFileContextUtil.test.ts Lines 314 to 345 in 4728b23
|
|
/runintegrationtests |
/retryBuilds |
## Problem aws#6225 - Didn't think 400% could be exceeded, but this one is especially volatile. Sometimes it barely spikes, and sometimes it goes crazy. ## Solution - Increase to 500% --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem
#6225
Solution
feature/x
branches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.