Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): sending metric data in onCodeGeneration #6226

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

siakmun-aws
Copy link
Contributor

@siakmun-aws siakmun-aws commented Dec 12, 2024

Problem

This is a part of the task to implement client side alarms in order to track success rate for the client.

Solution

  • Emit metric data telemetry on success/failure.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siakmun-aws siakmun-aws requested review from a team as code owners December 12, 2024 21:52
@siakmun-aws siakmun-aws changed the title Sending metric data in onCodeGeneration feat(amazonq) sending metric data in onCodeGeneration Dec 12, 2024
@siakmun-aws siakmun-aws changed the title feat(amazonq) sending metric data in onCodeGeneration feat(amazonq): sending metric data in onCodeGeneration Dec 12, 2024
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@siakmun-aws siakmun-aws marked this pull request as draft December 13, 2024 01:51
@siakmun-aws siakmun-aws force-pushed the siakmun/send-telemetry branch from 09141d3 to e312731 Compare December 17, 2024 22:19
@siakmun-aws siakmun-aws marked this pull request as ready for review December 18, 2024 00:24
@hayemaxi
Copy link
Contributor

hayemaxi commented Dec 18, 2024

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.

    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

You should use telemetry(amazonq) instead of feat in the commit and PR title to avoid this.

@@ -517,6 +559,7 @@ export class FeatureDevController {
}
}
}
await session.sendMetricDataTelemetry(MetricDataOperationName.END_CODE_GENERATION, MetricDataResult.SUCCESS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if these designs are final. But does it makes to just send a single metric instead of start/end? This would save some work on the server side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this design was to get the success rate by calculating end versus start, so we do need two separate metrics. Also, start can potentially fail too.

@siakmun-aws siakmun-aws changed the title feat(amazonq): sending metric data in onCodeGeneration telemetry(amazonq): sending metric data in onCodeGeneration Dec 18, 2024
@justinmk3 justinmk3 merged commit c449b0d into aws:master Dec 19, 2024
25 of 26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
This is a part of the task to implement client side alarms in order to
track success rate for the client.

- Emit metric data telemetry on success/failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants