-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry(amazonq): sending metric data in onCodeGeneration
#6226
Conversation
onCodeGeneration
onCodeGeneration
onCodeGeneration
onCodeGeneration
|
09141d3
to
e312731
Compare
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/.changes/next-release/Feature-06bf59c2-da3f-4ab5-ab86-634b3c25bd5e.json
Outdated
Show resolved
Hide resolved
You should use |
@@ -517,6 +559,7 @@ export class FeatureDevController { | |||
} | |||
} | |||
} | |||
await session.sendMetricDataTelemetry(MetricDataOperationName.END_CODE_GENERATION, MetricDataResult.SUCCESS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if these designs are final. But does it makes to just send a single metric instead of start/end? This would save some work on the server side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of this design was to get the success rate by calculating end versus start, so we do need two separate metrics. Also, start can potentially fail too.
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
…ab5-ab86-634b3c25bd5e.json Co-authored-by: Maxim Hayes <[email protected]>
onCodeGeneration
onCodeGeneration
…ab5-ab86-634b3c25bd5e.json
This is a part of the task to implement client side alarms in order to track success rate for the client. - Emit metric data telemetry on success/failure.
Problem
This is a part of the task to implement client side alarms in order to track success rate for the client.
Solution
feature/x
branches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.