Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(chat): try opt in implicit @workspace context once if users are in treatment group [WIP] #6217

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Dec 11, 2024

Problem

we found out the datapointss of implicit workspace #6098 experiment is too low and majority of users do not turn on workspace context configurable

Solution

similar to #5856 which targets amz internal users, the team decided to try turn on (only once) the configurable for a small fraction of all users (20%)


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua changed the title feat(chat): try opt in implicit @workspace context once if users are in treatment group config(chat): try opt in implicit @workspace context once if users are in treatment group Dec 11, 2024
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua
Copy link
Contributor Author

not quite sure if it's a "feat" or "config", personally i think "config" is better as it's a feature under testing and not officially launch

@Will-ShaoHua
Copy link
Contributor Author

this PR will be included in 12/17 release

@Will-ShaoHua Will-ShaoHua changed the title config(chat): try opt in implicit @workspace context once if users are in treatment group config(chat): try opt in implicit @workspace context once if users are in treatment group [WIP] Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant