refactor(sdkv3): migrate ssm client #6137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
Hweinstock
added a commit
that referenced
this pull request
Jan 27, 2025
## Problem Start the transition to sdkv3. This PR is just a start and is still missing a lot of features (see future work). Originally part of #5940, but decided to split it up. ## Solution - Do not overwrite existing builder to allow for incremental transition to V3. - A barebones working model, with the telemetry middleware implemented. - Expansion of testing for client construction. ## Future Work - Implement middleware for other relevant pieces (custom endpoints, logging, etc.). Hweinstock#4 - Increase testing coverage, specifically with credentials refreshing. (Hweinstock#3) - Migrate clients. (ssm: #6137) - Reduce boilerplate for client wrappers and have all clients call destroy. - Avoid recreating clients on each request, use singleton instead. - replace hand-made mocks with those from sdk mocking library: https://aws.amazon.com/blogs/developer/mocking-modular-aws-sdk-for-javascript-v3-in-unit-tests/ --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hweinstock
changed the title
justinmk3
reviewed
Jan 27, 2025
Hweinstock
force-pushed
the
sdkv3/migrateSSM
branch
from
47101f3 to
5904a28
Compare
jpinkney-aws
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a lot of duplicate code across the sdk clients. Additionally, we want to only construct the clients once (per wrapper), and have these clients call destroy.
Solution
Note: the line changes are mostly the added dependency of an
@aws-sdkclient and its hundreds of dependencies.ClientWrapperto minimize code dupe.Alternative Solution
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.