Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): dry run connection script to surface errors earlier. #6037

Merged
merged 22 commits into from
Dec 5, 2024
Merged

feat(ec2): dry run connection script to surface errors earlier. #6037

merged 22 commits into from
Dec 5, 2024

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Nov 15, 2024 •
edited
Loading

Problem

Follow up to #6018 (comment)

Solution

  • Run ssh within the same env as it will be run on real connection.
  • Log any resulting errors, and inform user where the process failed.
  • Also part of this PR is moving some functions to remoteSession.ts that are general enough to be there.

Error msg:
Screenshot 2024-11-15 at 5 53 51 PM

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@Hweinstock Hweinstock mentioned this pull request Nov 15, 2024
Closed
justinmk3
justinmk3 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Hweinstock Hweinstock changed the title feat(ec2): dry run connection script to surface errors earlier. (WIP) feat(ec2): dry run connection script to surface errors earlier. Nov 18, 2024
@Hweinstock Hweinstock marked this pull request as ready for review November 19, 2024 13:55
@Hweinstock Hweinstock requested a review from a team as a code owner November 19, 2024 13:55
@Hweinstock Hweinstock changed the base branch from master to feature/postreinvent December 4, 2024 19:20
justinmk3
justinmk3 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Hweinstock Hweinstock merged commit 4c38aab into aws:feature/postreinvent Dec 5, 2024
24 checks passed
@Hweinstock Hweinstock deleted the ec2/sshDryRun branch December 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hweinstock @justinmk3