deps(sdk): barebones general public client builder. #5940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
jpinkney-aws
reviewed
Nov 7, 2024
| } | ||
|
|
||
| export class Ec2Client { | ||
| export class Ec2Wrapper { |
There was a problem hiding this comment.
Out of curiosity what was the idea between calling it Ec2Wrapper? Is it because it's a toolkit wrapper around the sdk v3 builder?
There was a problem hiding this comment.
Yeah it seems like a more fitting name, and also because the EC2 v3 exports its client as EC2Client (instead of EC2 as in v2) so want to avoid confusion between the names. Do you think that renaming the 'clients' to 'wrappers' as we migrate them makes sense?
|
/retryBuilds |
|
This PR is too large, and I am unable to resolve build problems. Moving to #6097 |
Hweinstock
added a commit
that referenced
this pull request
Jan 27, 2025
## Problem Start the transition to sdkv3. This PR is just a start and is still missing a lot of features (see future work). Originally part of #5940, but decided to split it up. ## Solution - Do not overwrite existing builder to allow for incremental transition to V3. - A barebones working model, with the telemetry middleware implemented. - Expansion of testing for client construction. ## Future Work - Implement middleware for other relevant pieces (custom endpoints, logging, etc.). Hweinstock#4 - Increase testing coverage, specifically with credentials refreshing. (Hweinstock#3) - Migrate clients. (ssm: #6137) - Reduce boilerplate for client wrappers and have all clients call destroy. - Avoid recreating clients on each request, use singleton instead. - replace hand-made mocks with those from sdk mocking library: https://aws.amazon.com/blogs/developer/mocking-modular-aws-sdk-for-javascript-v3-in-unit-tests/ --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Start the transition to sdkv3. This PR is just a start, and is intended to serve as an opportunity to look at the design before building on it more. This is still missing a lot of features (see future work).
Excessive line changes are due to package-lock.json changes from install sdk-v3 clients.
Solution
Future Work
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.