test: try fix flaky test #4429
Merged
test: try fix flaky test #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Feb 13, 2024
Not sure if this fixes aws#4390, but we now reuse the same sandbox instead of recreating it each time. We were failing a test where a spied method was being called more than expected. Signed-off-by: nkomonen <[email protected]>
nkomonen-amazon
force-pushed
the
flakyTest
branch
from
37b39b5 to
870f494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this fixes #4390, but this will now reuse the same sandbox instead of recreating it
each time. We were failing a test where a spied method was being called more than expected.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.