Skip to content

Commit

Permalink
fix(lambda): drop delete action for lambda, s3 in AppBuilder #5922
Browse files Browse the repository at this point in the history
## Problem
When resources are provisioned and controlled through a SAM template,
customers should never modify resources directly as this such action
would create drift in the CFN template.

## Solution
Removed action to delete a Lambda or S3 bucket in the AppBuilder section
  • Loading branch information
seshubaws authored Nov 5, 2024
1 parent e40d586 commit 7f4517d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "AWS Lambda: Removed action to delete a Lambda or S3 bucket in the AppBuilder section as resources created through IaC frameworks should not be directly modified since this creates drift"
}
4 changes: 2 additions & 2 deletions packages/toolkit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1652,7 +1652,7 @@
},
{
"command": "aws.deleteLambda",
"when": "view =~ /^(aws.explorer|aws.appBuilder|aws.appBuilderForFileExplorer)$/ && viewItem =~ /^(awsRegionFunctionNode|awsRegionFunctionNodeDownloadable)$/ || viewItem == awsAppBuilderDeployedNode",
"when": "view =~ /^(aws.explorer)$/ && viewItem =~ /^(awsRegionFunctionNode|awsRegionFunctionNodeDownloadable)$/",
"group": "4@1"
},
{
Expand Down Expand Up @@ -1877,7 +1877,7 @@
},
{
"command": "aws.s3.deleteBucket",
"when": "view =~ /^(aws.explorer|aws.appBuilder|aws.appBuilderForFileExplorer)$/ && viewItem == awsS3BucketNode",
"when": "view =~ /^(aws.explorer)$/ && viewItem == awsS3BucketNode",
"group": "3@1"
},
{
Expand Down

0 comments on commit 7f4517d

Please sign in to comment.