feat(stepfunctions): Prevent launching Workflow Studio with invalid JSON + save metric refactoring #18146
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # github actions: https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-nodejs | |
| # setup-node: https://github.com/actions/setup-node | |
| name: CI | |
| on: | |
| push: | |
| branches: [master, staging] | |
| pull_request: | |
| # By default, CI will trigger on opened/synchronize/reopened event types. | |
| # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request | |
| # Note: To re-run `lint-commits` after fixing the PR title, close-and-reopen the PR. | |
| branches: [master, feature/*, staging] | |
| # Cancel old jobs when a pull request is updated. | |
| concurrency: | |
| group: ${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| jobs: | |
| lint-commits: | |
| # Note: To re-run `lint-commits` after fixing the PR title, close-and-reopen the PR. | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 20 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: '20' | |
| - name: Validate Branch name | |
| if: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref != ''}} | |
| env: | |
| BRANCH_NAME: ${{ github.event.pull_request.head.ref }} | |
| run: | | |
| node "$GITHUB_WORKSPACE/.github/workflows/lintbranch.js" run "$BRANCH_NAME" | |
| - name: Check PR title | |
| run: | | |
| node "$GITHUB_WORKSPACE/.github/workflows/lintcommit.js" | |
| lint: | |
| needs: lint-commits | |
| runs-on: ubuntu-latest | |
| strategy: | |
| matrix: | |
| node-version: [18.x] | |
| vscode-version: [stable] | |
| env: | |
| NODE_OPTIONS: '--max-old-space-size=8192' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Use Node.js ${{ matrix.node-version }} | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| - run: npm ci | |
| - run: npm run testCompile | |
| - run: npm run lint | |
| jscpd: | |
| needs: lint-commits | |
| if: ${{ github.event_name == 'pull_request'}} | |
| runs-on: ubuntu-latest | |
| strategy: | |
| matrix: | |
| node-version: [18.x] | |
| env: | |
| NODE_OPTIONS: '--max-old-space-size=8192' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 0 | |
| - name: Use Node.js ${{ matrix.node-version }} | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| - name: Fetch fork upstream | |
| env: | |
| REPO_NAME: ${{ github.event.pull_request.head.repo.full_name }} | |
| run: | | |
| git remote add forkUpstream https://github.com/$REPO_NAME # URL of the fork | |
| git fetch forkUpstream # Fetch fork | |
| - name: Compute git diff | |
| env: | |
| CURRENT_BRANCH: ${{ github.head_ref }} | |
| TARGET_BRANCH: ${{ github.event.pull_request.base.ref }} | |
| run: git diff --name-only origin/$TARGET_BRANCH forkUpstream/$CURRENT_BRANCH > diff_output.txt | |
| - run: npm install -g jscpd | |
| - run: jscpd --config "$GITHUB_WORKSPACE/.github/workflows/jscpd.json" | |
| - if: always() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: unfiltered-jscpd-report | |
| path: ./jscpd-report.json | |
| - name: Filter jscpd report for changed files | |
| run: | | |
| if [ ! -f ./jscpd-report.json ]; then | |
| echo "jscpd-report.json not found" | |
| exit 1 | |
| fi | |
| echo "Filtering jscpd report for changed files..." | |
| CHANGED_FILES=$(jq -R -s -c 'split("\n")[:-1]' diff_output.txt) | |
| echo "Changed files: $CHANGED_FILES" | |
| jq --argjson changed_files "$CHANGED_FILES" ' | |
| .duplicates | map(select( | |
| (.firstFile?.name as $fname | $changed_files | any(. == $fname)) or | |
| (.secondFile?.name as $sname | $changed_files | any(. == $sname)) | |
| )) | |
| ' ./jscpd-report.json > filtered-jscpd-report.json | |
| cat filtered-jscpd-report.json | |
| - name: Check for duplicates | |
| run: | | |
| if [ $(wc -l < ./filtered-jscpd-report.json) -gt 1 ]; then | |
| echo "filtered_report_exists=true" >> $GITHUB_ENV | |
| else | |
| echo "filtered_report_exists=false" >> $GITHUB_ENV | |
| fi | |
| - name: upload filtered report (if applicable) | |
| if: env.filtered_report_exists == 'true' | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: filtered-jscpd-report | |
| path: ./filtered-jscpd-report.json | |
| - name: Fail and log found duplicates. | |
| if: env.filtered_report_exists == 'true' | |
| run: | | |
| cat ./filtered-jscpd-report.json | |
| echo "Duplications found, failing the check." | |
| exit 1 | |
| macos: | |
| needs: lint-commits | |
| name: test macOS | |
| runs-on: macos-latest | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| node-version: [18.x] | |
| vscode-version: [minimum, stable, insiders] | |
| env: | |
| VSCODE_TEST_VERSION: ${{ matrix.vscode-version }} | |
| NODE_OPTIONS: '--max-old-space-size=8192' | |
| AWS_TOOLKIT_TEST_CACHE_DIR: '/tmp/.vscode-test/' | |
| AWS_TOOLKIT_TEST_USER_DIR: '/tmp/.vscode-test/user-data/' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Use Node.js ${{ matrix.node-version }} | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| - run: npm ci | |
| - name: Tests | |
| uses: coactions/setup-xvfb@v1 | |
| with: | |
| run: npm test | |
| - name: Code coverage (Toolkit) | |
| env: | |
| # Unset NODE_OPTIONS because of https://github.com/codecov/uploader/issues/475 | |
| NODE_OPTIONS: '' | |
| if: ${{ github.repository == 'aws/aws-toolkit-vscode' && github.event_name == 'pull_request' && github.base_ref == 'master' }} | |
| uses: codecov/codecov-action@v5 | |
| with: | |
| flags: macos-toolkit-unittests | |
| verbose: true | |
| file: ./coverage/toolkit/lcov.info | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| - name: Code coverage (Amazon Q) | |
| env: | |
| # Unset NODE_OPTIONS because of https://github.com/codecov/uploader/issues/475 | |
| NODE_OPTIONS: '' | |
| if: ${{ github.repository == 'aws/aws-toolkit-vscode' && github.event_name == 'pull_request' && github.base_ref == 'master' }} | |
| uses: codecov/codecov-action@v5 | |
| with: | |
| flags: macos-amazonq-unittests | |
| verbose: true | |
| file: ./coverage/amazonq/lcov.info | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| web: | |
| needs: lint-commits | |
| name: test Web | |
| runs-on: ubuntu-latest | |
| strategy: | |
| fail-fast: true | |
| matrix: | |
| node-version: [18.x] | |
| vscode-version: [stable, insiders] | |
| env: | |
| VSCODE_TEST_VERSION: ${{ matrix.vscode-version }} | |
| NODE_OPTIONS: '--max-old-space-size=8192' | |
| AWS_TOOLKIT_TEST_CACHE_DIR: '/tmp/.vscode-test/' | |
| AWS_TOOLKIT_TEST_USER_DIR: '/tmp/.vscode-test/user-data/' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Use Node.js ${{ matrix.node-version }} | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| - run: npm ci | |
| - name: Tests | |
| uses: coactions/setup-xvfb@v1 | |
| with: | |
| run: npm run testWeb | |
| windows: | |
| needs: lint-commits | |
| name: test Windows | |
| runs-on: windows-2019 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| node-version: [18.x] | |
| vscode-version: [stable, insiders] | |
| env: | |
| VSCODE_TEST_VERSION: ${{ matrix.vscode-version }} | |
| NODE_OPTIONS: '--max-old-space-size=8192' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Use Node.js ${{ matrix.node-version }} | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| - run: npm ci | |
| - name: Tests | |
| run: npm test | |
| - name: Code coverage | |
| env: | |
| # Unset NODE_OPTIONS because of https://github.com/codecov/uploader/issues/475 | |
| NODE_OPTIONS: '' | |
| if: ${{ github.repository == 'aws/aws-toolkit-vscode' && github.event_name == 'pull_request' && github.base_ref == 'master' }} | |
| uses: codecov/codecov-action@v5 | |
| with: | |
| flags: windows-unittests | |
| verbose: true | |
| file: ./coverage/lcov.info | |
| token: ${{ secrets.CODECOV_TOKEN }} |