Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out frequent client error from codegeneration telemetry #5342

Closed
wants to merge 1 commit into from

Conversation

linyuxi-0511
Copy link

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Exclude frequent client errors from faults, they should be errors.

Checklist

  • [ x] My code follows the code style of this project
  • [ x] I have added tests to cover my changes
  • [ x] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • [ n/a] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linyuxi-0511 linyuxi-0511 requested review from a team as code owners February 7, 2025 18:51
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Filter client errors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change is not customer facing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. This is not needed. Will remove.

MetricDataOperationName.EndCodeGeneration,
MetricDataResult.Fault
)
}
session.sendMetricDataTelemetry(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sending metrics twice

@linyuxi-0511 linyuxi-0511 closed this by deleting the head repository Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants