-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry(amazonq): refactor doc telemetry to v2 version #5316
Open
KevinDing1
wants to merge
5
commits into
aws:main
Choose a base branch
from
KevinDing1:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDing1
commented
Feb 3, 2025
...mmunity/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/BuildStepStatus.kt
Outdated
Show resolved
Hide resolved
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonqDoc/session/DocSession.kt
Fixed
Show fixed
Hide fixed
KevinDing1
force-pushed
the
main
branch
2 times, most recently
from
February 3, 2025 23:54
de470fe
to
9d1c752
Compare
rli
reviewed
Feb 4, 2025
plugins/core/sdk-codegen/codegen-resources/codewhispererruntime/service-2.json
Outdated
Show resolved
Hide resolved
avi-alpert
approved these changes
Feb 4, 2025
dhasani23
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The “TODO” for /transform needs to be addressed first; see my above comment
Done |
dhasani23
approved these changes
Feb 6, 2025
dgss
approved these changes
Feb 7, 2025
viktorsaws
approved these changes
Feb 7, 2025
KevinDing1
force-pushed
the
main
branch
2 times, most recently
from
February 7, 2025 19:54
2311317
to
622de5a
Compare
* feat(amazonq): support Java 21 * fix detekt * add test * update strings * update text * fix detekt * add jvm_21 * update strings * remove comment / unneeded notif --------- Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.