-
Notifications
You must be signed in to change notification settings - Fork 262
feat(amazonq): Prefetch next inline recommendation #5290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Feb 3, 2025
...ware/aws/toolkits/jetbrains/services/codewhisperer/credentials/CodeWhispererClientAdaptor.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Feb 3, 2025
...ommunity/tst/software/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererTestBase.kt
Outdated
Show resolved
Hide resolved
...ity/tst/software/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererTelemetryTest.kt
Outdated
Show resolved
Hide resolved
...y/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererService.kt
Outdated
Show resolved
Hide resolved
...y/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererService.kt
Show resolved
Hide resolved
} | ||
val nextRecommendationContext = RecommendationContext(detailContexts, "", "", newVisualPosition) | ||
val newPopup = withContext(EDT) { | ||
JBPopupFactory.getInstance().createMessage("Dummy popup") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just handle the case where there is no prior popup there?
…/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererTelemetryTest.kt Co-authored-by: Richard Li <[email protected]>
…/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererTestBase.kt Co-authored-by: Richard Li <[email protected]>
…48/aws-toolkit-jetbrains into prefetchNextInlineRecommendation
Will-ShaoHua
reviewed
Feb 4, 2025
.changes/next-release/feature-af284b37-980e-4f98-a653-5fef6a71519b.json
Outdated
Show resolved
Hide resolved
Will-ShaoHua
approved these changes
Feb 4, 2025
rli
approved these changes
Feb 4, 2025
Draft
4 tasks
KevinDing1
pushed a commit
to KevinDing1/aws-toolkit-jetbrains
that referenced
this pull request
Feb 6, 2025
This PR introduces the ability for users to see the next recommendation immediately after accepting the current one, provided there is a subsequent recommendation available. The key enhancements include: Automatic Prefetching: Introduced a function that calls the CodeWhisperer API to fetch the next recommendation while the current one is being reviewed. Session Promotion Added functionality to display the next recommendation instantly upon accepting the current recommendation (if there is one) Helper Utilities: Implemented helper functions to calculate the necessary file information for the next request and to send telemetry events related to the subsequent recommendation.
evanliu048
added a commit
to evanliu048/aws-toolkit-jetbrains
that referenced
this pull request
Feb 12, 2025
This reverts commit 805cb39.
rli
pushed a commit
that referenced
this pull request
Feb 13, 2025
gandhi-21
pushed a commit
to gandhi-21/aws-toolkit-jetbrains
that referenced
this pull request
Feb 26, 2025
This PR introduces the ability for users to see the next recommendation immediately after accepting the current one, provided there is a subsequent recommendation available. The key enhancements include: Automatic Prefetching: Introduced a function that calls the CodeWhisperer API to fetch the next recommendation while the current one is being reviewed. Session Promotion Added functionality to display the next recommendation instantly upon accepting the current recommendation (if there is one) Helper Utilities: Implemented helper functions to calculate the necessary file information for the next request and to send telemetry events related to the subsequent recommendation.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR introduces the ability for users to see the next recommendation immediately after accepting the current one, provided there is a subsequent recommendation available. The key enhancements include:
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.