Set expiry for dismissed notifications #5186
Open
+146
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
manodnyab
reviewed
Jan 2, 2025
| } | ||
|
|
||
| data class DismissedNotification( | ||
| @Attribute |
There was a problem hiding this comment.
are the attribute tags required here?
| ) | ||
|
|
||
| data class NotificationDismissalConfiguration( | ||
| @Property |
|
|
||
| data class NotificationDismissalConfiguration( | ||
| @Property | ||
| var dismissedNotifications: MutableSet<DismissedNotification> = mutableSetOf(), |
There was a problem hiding this comment.
Suggested change
| var dismissedNotifications: MutableSet<DismissedNotification> = mutableSetOf(), | |
| val dismissedNotifications: MutableSet<DismissedNotification> = mutableSetOf(), |
|
|
||
| override fun getState(): NotificationDismissalConfiguration = state | ||
|
|
||
| override fun loadState(state: NotificationDismissalConfiguration) { | ||
| this.state.dismissedNotificationIds.clear() | ||
| this.state.dismissedNotificationIds.addAll(state.dismissedNotificationIds) | ||
| this.state.dismissedNotifications.clear() |
There was a problem hiding this comment.
Why do we need to clear the set? Wont each value anyway be unique since it's a set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
We store the list of dismissed notif ids in aws.xml, but we need to limit the size of this saved list.
To do this, dismissed notification IDs stored in the aws.xml are timestamped. Each time the persistent state component is loaded, any notifications older than 60 days will be removed from the set.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.