-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DO NOT MERGE] Add GitHub workflow for test account #3340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: version-3
Are you sure you want to change the base?
Conversation
|
Detected 1 possible performance regressions:
|
| name: Build SDK | ||
| on: | ||
| pull_request_review: | ||
| types: [ submitted ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to look over other implementations - they used different activity types and we might want to consider those as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could edit the workflow so that it runs for any open PR. My main concern for this would be that every time a new commit is pushed the workflow runs again, and these start up CodeBuild jobs which might be resource expensive. I feel like this workflow should only be run when the PR is in a pretty finalized state. For now I think I'll modify this to be like the CPP one so we can test, but afterwards we should consider how often this should run.
Adds Catapult GitHub PR support for dev account for testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!