Skip to content

Conversation

@richardwang1124
Copy link
Contributor

Adds Catapult GitHub PR support for dev account for testing.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Detected 1 possible performance regressions:

  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 64.26 -> 64.41. Z-score: 39.22

name: Build SDK
on:
pull_request_review:
types: [ submitted ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to look over other implementations - they used different activity types and we might want to consider those as well.

Copy link
Contributor Author

@richardwang1124 richardwang1124 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could edit the workflow so that it runs for any open PR. My main concern for this would be that every time a new commit is pushed the workflow runs again, and these start up CodeBuild jobs which might be resource expensive. I feel like this workflow should only be run when the PR is in a pretty finalized state. For now I think I'll modify this to be like the CPP one so we can test, but afterwards we should consider how often this should run.

@richardwang1124 richardwang1124 changed the title Add GitHub workflow for test account [DO NOT MERGE] Add GitHub workflow for test account Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants