Relocate ActionMailbox #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssunday fyi |
ssunday
suggested changes
Nov 13, 2024
ssunday
reviewed
Nov 13, 2024
| @@ -1,3 +1,3 @@ | |||
| options = {} | |||
| ActionMailer::Base.add_delivery_method :ses, Aws::ActionMailer::SESMailer, **options | |||
| ActionMailer::Base.add_delivery_method :ses_v2, Aws::ActionMailer::SESV2Mailer, **options | |||
| ActionMailer::Base.add_delivery_method :ses, Aws::ActionMailer::SES::Mailer, **options | |||
There was a problem hiding this comment.
isn't this an unrelated to mailbox change
There was a problem hiding this comment.
It's in the sample-app. A change I made for the other gem. I just forgot to change it here, and when testing ActionMailbox, I got an unrelated error.
Yes. I can do this now. My original plan was to just do a sweeping clean up after I got all of the functionality out. |
alextwoods
approved these changes
Nov 13, 2024
|
@ssunday All approved from our side. I think you can actually test this if you pull in aws-sdk-rails from github/branch in your gemfile, this gem and the other gems the same way. It should all still work. Otherwise, we can defer that and if you want to give approves that's fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocates the ActionMailbox SES feature to aws/aws-actionmailbox-ses-ruby#1