refactor: Remove default assignment and obsolete attribute from AWSTo…

…kenProvider property
aws · Jan 30, 2025 · 4c632b8 · 4c632b8
1 parent 63cb4e0
commit 4c632b8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/sdk/src/Core/Amazon.Runtime/ClientConfig.cs b/sdk/src/Core/Amazon.Runtime/ClientConfig.cs
@@ -95,7 +95,7 @@ public abstract partial class ClientConfig : IClientConfig
         private bool didProcessServiceURL = false;
         private AWSCredentials _defaultAWSCredentials = null;
         private IIdentityResolverConfiguration _identityResolverConfiguration = DefaultIdentityResolverConfiguration.Instance;
-        private IAWSTokenProvider _awsTokenProvider = new DefaultAWSTokenProviderChain();
+        private IAWSTokenProvider _awsTokenProvider;
         private TelemetryProvider telemetryProvider = AWSConfigs.TelemetryProvider;
         private AccountIdEndpointMode? accountIdEndpointMode = null;
 
@@ -202,7 +202,6 @@ public IIdentityResolverConfiguration IdentityResolverConfiguration
         }
 
         /// <inheritdoc />
-        [Obsolete("This property is deprecated in favor of the new Identity resolvers configured through IdentityResolverConfiguration.")]
         public IAWSTokenProvider AWSTokenProvider
         {
             get { return this._awsTokenProvider; }

diff --git a/sdk/src/Core/Amazon.Runtime/Credentials/DefaultAWSTokenIdentityResolver.cs b/sdk/src/Core/Amazon.Runtime/Credentials/DefaultAWSTokenIdentityResolver.cs
@@ -26,10 +26,8 @@ public class DefaultAWSTokenIdentityResolver : IIdentityResolver<AWSToken>
     {
         private readonly IAWSTokenProvider _tokenProvider;
 
-        public DefaultAWSTokenIdentityResolver() : this(null) { }
-
-        public DefaultAWSTokenIdentityResolver(string profileName)
-            => _tokenProvider = new AWSTokenProviderChain(new ProfileTokenProvider(profileName));
+        public DefaultAWSTokenIdentityResolver() 
+            => _tokenProvider = new AWSTokenProviderChain(new ProfileTokenProvider());
 
         BaseIdentity IIdentityResolver.ResolveIdentity()
         {

diff --git a/sdk/src/Core/Amazon.Runtime/IClientConfig.cs b/sdk/src/Core/Amazon.Runtime/IClientConfig.cs
@@ -21,6 +21,7 @@
 using Amazon.Runtime.Telemetry;
 using Amazon.Runtime.Credentials.Internal;
 using Amazon.Runtime.Identity;
+using Amazon.Runtime.Credentials;
 
 #if NETSTANDARD
 using System.Net.Http;
@@ -84,10 +85,12 @@ public partial interface IClientConfig
         IIdentityResolverConfiguration IdentityResolverConfiguration { get; }
 
         /// <summary>
-        /// For Services using Bearer authentication, this controls how <see cref="BearerTokenSigner"/>
+        /// For services using Bearer authentication, this provider can be used to override how the <see cref="BearerTokenSigner"/>
         /// resolves a <see cref="AWSToken"/>.
         /// <para />
         /// See <see cref="DefaultAWSTokenProviderChain"/> for additional information.
+        /// <para />
+        /// If null, the SDK will use the <see cref="DefaultAWSTokenIdentityResolver"/> to resolve the bearer token.
         /// </summary>
         IAWSTokenProvider AWSTokenProvider { get; }