Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: S3 add an option to enable/disable "Expect: 100-continue" headers #2780

Conversation

ThomasVille
Copy link

@ThomasVille ThomasVille commented Jul 23, 2019

Since #437, when using Riak-CS v2.1.1 as backend, uploading files larger than 1MB using streams on NodeJS leads to corrupted data stored in Riak-CS.

This PR adds an option to prevent the Expect: 100-continue header from being added to the content of the file when uploading a large file.

Fixes basho/riak_cs#1327.

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • non-code related change (markdown/git settings etc)

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #2780 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
+ Coverage   96.91%   96.91%   +<.01%     
==========================================
  Files         293      293              
  Lines        8805     8808       +3     
  Branches     1651     1652       +1     
==========================================
+ Hits         8533     8536       +3     
  Misses        272      272
Impacted Files Coverage Δ
lib/config.js 87.2% <ø> (ø) ⬆️
lib/services/s3.js 98.16% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4d96e...8a30bba. Read the comment docs.

@trivikr
Copy link
Member

trivikr commented Jul 23, 2019

@ThomasVille Looks like the email address in the git config for this PR is not registered with GitHub.
Either register that email address with GitHub or override your git history with your registered email address (details)

@ThomasVille ThomasVille force-pushed the feature-s3-add-option-to-enable-expect-100-headers branch from 27c1b2c to 8a30bba Compare July 23, 2019 15:49
@ThomasVille
Copy link
Author

ThomasVille commented Jul 23, 2019

@trivikr I tried overriding the history of the branch with my registered email address by rebasing then amending my own commits however it seems that I now appear as the commiter of all the commits of the awstools account...

Is this an issue?

@trivikr
Copy link
Member

trivikr commented Jul 23, 2019

Yup, PR shows conflicts need to be resolved.
You can try fixing it by overriding just your commits. An easy option would be to cherry-pick your commits to new branch (as there are only four of them) and create new PR.

@ThomasVille
Copy link
Author

Thank you @trivikr for your help.

New PR created here #2783.

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart upload fails (AccessDenied) when using Nodejs aws-sdk client with v2 signature [JIRA: RCS-380]
6 participants