URL-decode subresource values as well as other query parameters

aws · Mar 12, 2015 · 2930831 · 2930831
1 parent eb83937
commit 2930831
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/lib/signers/s3.js b/lib/signers/s3.js
@@ -127,11 +127,7 @@ AWS.Signers.S3 = inherit(AWS.Signers.RequestSigner, {
         if (this.subResources[name] || this.responseHeaders[name]) {
           var subresource = { name: name };
           if (value !== undefined) {
-            if (this.subResources[name]) {
-              subresource.value = value;
-            } else {
-              subresource.value = decodeURIComponent(value);
-            }
+            subresource.value = decodeURIComponent(value);
           }
           resources.push(subresource);
         }

diff --git a/test/signers/s3.spec.coffee b/test/signers/s3.spec.coffee
@@ -273,7 +273,7 @@ describe 'AWS.Signers.S3', ->
 
 
       x-amz-date:DATE-STRING
-      /?versionId=a%2Bb
+      /?versionId=a+b
       """)
 
     it 'includes the non-encoded query string get header overrides', ->