Fix NPE in DoubleAttributeConverter and FloatAttributeConverter for null input#6782
Open
S-Saranya1 wants to merge 3 commits intomasterfrom
Open
Fix NPE in DoubleAttributeConverter and FloatAttributeConverter for null input#6782S-Saranya1 wants to merge 3 commits intomasterfrom
S-Saranya1 wants to merge 3 commits intomasterfrom
Conversation
… replace auto-unboxing NPE
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


DoubleAttributeConverter.transformFrom() and FloatAttributeConverter.transformFrom() throw a cryptic NullPointerException (no message) when called with a null input due to
auto-unboxing in ConverterUtils.validateDouble()/validateFloat(). This occurs when users persist a Map<String, Double> or List containing null values.
Motivation and Context
The AttributeConverter.transformFrom() interface contract states it should raise a RuntimeException if the input is null. The existing code does throw, but accidentally via auto-unboxing — producing a bare NPE with no useful message. This fix replaces the accidental NPE with an explicit Validate.paramNotNull check that throws
NullPointerException with a clear "input must not be null" message.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License