Allow unquoted account ids in IAM Policies

[alextwoods]

Allow unquoted AWS account ids in IAM Policies

Motivation and Context

IAM Policies with unquoted (numeric) AWS account ids are considered valid by IAM and work as intended, however, our existing IAM Policy reader/validation considers these invalid. Additionally, IAM considers unquoted boolean values in conditions as valid, but these are also rejected by the current SDK validation.

Reference: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies.html

Modifications

• Allow unquoted accountIds and booleans in limited contexts.

This PR loosens validations in limited contexts where either unquoted accountIDs or booleans may appear and be valid - these are limited to Principals and Conditions only. Principals may have unquoted accountIds and Conditions may have unquoted account ids and booleans.

Note that although AWS account ids may have leading zeros, IAM will reject Policy Documents with unquoted account ids with leading zeros - these are invalid JSON and are not supported - server side validation rejects these. Policy documents with these will still be considered invalid by the SDK reader.

Testing

New and existing unit tests.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud