Skip to content

Conversation

@davidh44
Copy link
Contributor

@davidh44 davidh44 commented Oct 27, 2025

Motivation and Context

In multi line commands, a subsequent successful command will mask a previous command that fails

Modifications

Add set -e to beginning of multi line commands

Testing

Tested in CodeBuild runs

@davidh44 davidh44 requested a review from a team as a code owner October 27, 2025 20:48
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@S-Saranya1
Copy link
Contributor

Do we need to add this to buildspecs/update-master-from-release.yml as well? It looks like it also has a multi-command script block. And for s3-regression-tests.yml, it is covered in another PR, correct?

@davidh44
Copy link
Contributor Author

Do we need to add this to buildspecs/update-master-from-release.yml as well? It looks like it also has a multi-command script block. And for s3-regression-tests.yml, it is covered in another PR, correct?

update-master-from-release.yml is already handled with the OR operator in the mvn versions command
s3-regression-tests will be updated once the tests are fixed

@davidh44 davidh44 added this pull request to the merge queue Oct 27, 2025
Merged via the queue into master with commit 8a76ddf Oct 27, 2025
36 of 37 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2025
@davidh44 davidh44 deleted the hdavidh/buildspecs-set-e branch October 27, 2025 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants