Skip to content

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Oct 16, 2025

Motivation and Context

Clean up duplicate checksum logic in legacy checksum classes ("auth") and new checksum classes ("checksums"):

  • Internal APIs: CrtBasedChecksumProvider, SdkCrc32 and SdkCrc32C
    • Remove duplicate checksumming logic that is in internal packages:
  • Protected APIs:*Checksum classes such as Sha1Checksum:
    • we can't remove them because even though they are marked as private APIs, they are not in "internal" package properly. I made the change to remove the logic and reuse the new checksum logic

@zoewangg zoewangg requested a review from a team as a code owner October 16, 2025 21:50
@zoewangg zoewangg force-pushed the zoewang/AddressDuplicateCodePart2 branch from 4545895 to 7a26806 Compare October 17, 2025 17:21
@zoewangg zoewangg force-pushed the zoewang/AddressDuplicateCodePart2 branch from 7a26806 to c61dfb4 Compare October 17, 2025 17:25
Copy link

@zoewangg zoewangg merged commit 21479fe into feature/master/technicaldebt-duplicatecode Oct 17, 2025
27 of 29 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants