Skip to content

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 14, 2025

Motivation and Context

This PR adds support for async payload signing in the V4a signer. Note an important difference to the V4 implementation: This supports the fallback to signing the payload when the request is sent over http. This is because calling the signAsync() method previously always threw UnsupportedOperationException, so there is no risk of performance regression for existing users.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the dongie/sra-chunk-encoding-pt2 branch 5 times, most recently from 966149f to ef5d53f Compare October 16, 2025 18:42
@dagnir dagnir changed the base branch from dongie/sra-chunk-encoding-pt1 to feature/master/sra-async-chunked-encoding October 16, 2025 18:59
@dagnir dagnir force-pushed the dongie/sra-chunk-encoding-pt2 branch from ef5d53f to d4f0f87 Compare October 16, 2025 19:03
@dagnir dagnir force-pushed the dongie/sra-chunk-encoding-pt2 branch from d4f0f87 to 5ac3968 Compare October 17, 2025 14:00
@dagnir dagnir changed the title [WIP] V4a async payload signing V4a async payload signing Oct 17, 2025
Copy link

import software.amazon.awssdk.utils.async.ByteBufferStoringSubscriber.TransferResult;

@SdkInternalApi
public final class CrtRequestBodyAdapter implements HttpRequestBodyStream {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this existing class https://github.com/aws/aws-sdk-java-v2/blob/master/http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/request/CrtRequestBodyAdapter.java to crt-core and use it directly? I understand this means we'd need to make it protected APIs, but the API surface area seems small enough...


@ParameterizedTest(name = "{index} {3}")
@MethodSource("streamingInputChecksumCalculationParams")
public void asyncStreamingInput_checksumCalculation(RequestChecksumCalculation requestChecksumCalculation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an integ test as well?

SdkHttpRequest.Builder request, Publisher<ByteBuffer> payload, String checksum) {

return SignerUtils.moveContentLength(request, payload)
.thenApply(p -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is there any difference between sigv4a and sigv4 for this logic here?


encodedContentLength += calculateExistingTrailersLength();

switch (checksum) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here, can we reuse the logic somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants