Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support auto generated timestamp in nested objects #5960

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ghetelgb
Copy link

@ghetelgb ghetelgb commented Mar 14, 2025

Motivation and Context

Expected behavior: Using auto generated timestamp extension should work on nested objects too. (previously, they would only work on root level of the records)

Modifications

Fix: The beforeWrite() method for the implementation of the auto generated timestamp extension was updated to iterate over attributes in a recursive way in order to find and set current instant time for annotated attributes within the nested objects.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@ghetelgb ghetelgb requested a review from a team as a code owner March 14, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant