Migration Tool: PutObjectRequest File/InputStream transform

[davidh44]

Motivation and Context

Modifications

Refactored common code to S3TransformUtils (separate commit)

Transforms for PutObjectRequest:

• Constructors:
  PutObjectRequest(String bucketName, String key, File file)
PutObjectRequest(String bucketName, String key, String redirectLocation)
• Setters:
  withFile setFile
withInputStream setInputStream
withRequesterPays
withBucketName
withCannedAcl

Transforms for AmazonS3.putObject(PutObjectRequest)

• If no payload set: RequestBody.empty()
• If File set: RequestBody.fromFile()
• If InputStream set:
  • If Content-Length provided: RequestBody.fromInputStream(inputStream, contentLength)
  • Else: RequestBody.fromContentProvider(() -> inputStream, "binary/octet-stream") (comment will be added to tell users to specify length, and warn stream will be buffered)

Transforms for TransferManager.upload(PutObjectRequest)

• If no payload set: tm.upload(UploadRequest...requestBody(AsyncRequestBody.empty())
• If File set: tm.uploadFile(UploadFileRequest...source(file)
• If InputStream set:
  • If Content-Length not provided, will default to -1
  • Undefined variable will be passed to ExecutorService arg, transformed code will fail at runtime (comment will be added to tell users to set):
  • tm.upload(UploadRequest...requestBody(AsyncRequestBody.fromInputStream(inputStream, contentLength, newExecutorServiceVariableToDefine)

TODO in follow up PRs:

1. transform ObjectMetadata and pass on Content-Length to RequestBody.fromInputStream() / AsyncRequestBody.fromInputStream()
2. remaining PutObjectRequest setters

Testing

added end to end tests

[sonarqubecloud]

Quality Gate failed

Failed conditions
5.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE