Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue that the SDK unnecessarily bufferred the entire conten… #5855

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Feb 4, 2025

…t for streaming operations

Motivation and Context

Fixed an issue that the SDK unnecessarily buffered the entire content for streaming operations. See
#5850

We changed RequestBody#fromContenProvider to buffer content in 9523cf5#diff-1a88bd363dd55e33ebf3734f8a96c524d600b3f46745c82169482718d43c030a commit. It was released in 2.30.9.

The root cause is that we are calling RequestBody#fromContenProvider in BaseClientHandler within the SDK to wrap the inputstream with SdkLengthAwareInputStream, which means all streams with known content length will be buffered.

Modifications

Create an internal class to extend RequestBody that just uses the contentStreamProvider as-is (instead of buffering).

Testing

Tested with customer's repro code and verified oom is no longer thrown

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg force-pushed the zoewang/avoidBufferMemory branch from eb5c8b6 to 60baa3a Compare February 4, 2025 00:07
@zoewangg zoewangg marked this pull request as ready for review February 4, 2025 00:09
@zoewangg zoewangg requested a review from a team as a code owner February 4, 2025 00:09
@zoewangg zoewangg added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit 7ca84b8 Feb 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants