Fixed an issue that the SDK unnecessarily bufferred the entire conten… #5855
+67
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t for streaming operations
Motivation and Context
Fixed an issue that the SDK unnecessarily buffered the entire content for streaming operations. See
#5850
We changed
RequestBody#fromContenProvider
to buffer content in 9523cf5#diff-1a88bd363dd55e33ebf3734f8a96c524d600b3f46745c82169482718d43c030a commit. It was released in 2.30.9.The root cause is that we are calling
RequestBody#fromContenProvider
in BaseClientHandler within the SDK to wrap the inputstream withSdkLengthAwareInputStream
, which means all streams with known content length will be buffered.Modifications
Create an internal class to extend
RequestBody
that just uses the contentStreamProvider as-is (instead of buffering).Testing
Tested with customer's repro code and verified oom is no longer thrown
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License