Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
davidh44 committed Feb 4, 2025
1 parent ed58871 commit 75577b4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .changes/next-release/feature-NettyNIOHTTPClient-8f8589d.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "feature",
"category": "Netty NIO HTTP Client",
"contributor": "",
"description": "Fallback to prior knowledge if default client setting is ALPN and request has HTTP endpoint"
}
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ private void failIfAlpnUsedWithHttp(AsyncExecuteRequest request) {
if (isAlpnUserConfigured) {
throw new UnsupportedOperationException("ALPN can only be used with HTTPS, not HTTP.");
}
if (protocolNegotiation == ProtocolNegotiation.ALPN) {
log.debug(null, () -> "Default client protocol negotiation is ALPN, but request endpoint is HTTP. Prior "
+ "knowledge negotiation will be used instead");
}
}
}

Expand Down

0 comments on commit 75577b4

Please sign in to comment.