Stop populating SessionMode by default for the SDK-created S3 express…

… sessions. This value already matched the service-side default, and was already not sent by most SDK languages.
aws · Jan 30, 2025 · 4489294 · 4489294
1 parent 02319ad
commit 4489294
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changes/next-release/bugfix-AmazonS3-6b41d5e.json b/.changes/next-release/bugfix-AmazonS3-6b41d5e.json
@@ -0,0 +1,6 @@
+{
+    "type": "bugfix",
+    "category": "Amazon S3",
+    "contributor": "",
+    "description": "Stopped populating SessionMode by default for the SDK-created S3 express sessions. This value already matched the service-side default, and was already not sent by most SDK languages."
+}
diff --git a/...in/java/software/amazon/awssdk/services/s3/internal/s3express/S3ExpressIdentityCache.java b/...in/java/software/amazon/awssdk/services/s3/internal/s3express/S3ExpressIdentityCache.java
@@ -103,7 +103,6 @@ SessionCredentials getCredentials(S3ExpressIdentityKey key, IdentityProvider<Aws
         Duration requestApiCallTimeout = clientSetTimeoutIfExists(serviceClientConfiguration).orElse(DEFAULT_API_CALL_TIMEOUT);
 
         return CreateSessionRequest.builder().bucket(bucket)
-                     .sessionMode(SessionMode.READ_WRITE)
                      .overrideConfiguration(o -> o.credentialsProvider(provider)
                                                   .apiCallTimeout(requestApiCallTimeout)).build();
     }

diff --git a/...es/s3/src/test/java/software/amazon/awssdk/services/s3/functionaltests/S3ExpressTest.java b/...es/s3/src/test/java/software/amazon/awssdk/services/s3/functionaltests/S3ExpressTest.java
@@ -264,7 +264,7 @@ private static void verifyGetObject(S3ExpressSessionAuth s3ExpressSessionAuth) {
 
     private static void verifySessionHeaders() {
         verify(1, getRequestedFor(urlMatching("/.*session"))
-            .withHeader("x-amz-create-session-mode", equalTo("ReadWrite"))
+            .withoutHeader("x-amz-create-session-mode")
             .withHeader("x-amz-content-sha256", equalTo("UNSIGNED-PAYLOAD")));
     }