Feat tmv2 audit #3249
Merged
Feat tmv2 audit #3249
+1,889
−1,091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Dec 15, 2025
| if err != nil { | ||
| d.setErr(fmt.Errorf("error when heading info of object %s: %v", data.key, err)) | ||
| } else { | ||
| d.incrObjectsFailed(1) |
Contributor
There was a problem hiding this comment.
above you mention about object failed
this value might not be the real number of failure if user passed a customized failure policy
but couldn't we just still increment the count of objects failed, even if the user passes a custom policy?
Contributor
Author
There was a problem hiding this comment.
I mean it depends on how we define this field and how user implements the policy. If user policy retried the request and succeeded, they might not consider that object as a failed count
Contributor
There was a problem hiding this comment.
You're right, thinking more about it, it's only if the retry policy also returns an error that this counts as failed.
However, I still think that we have an accurate count of failed get/uploads
- If user provides standard policies, we are counting correctly
- If user provides their own policies, and they successfully/unsuccessfully retry, we would still know whether it was successful or not depending on whether they return
error not
wty-Bryant
force-pushed
the
feat-tmv2-audit
branch
2 times, most recently
from
f2aee8a to
2bbe6ef
Compare
lucix-aws
reviewed
Dec 18, 2025
lucix-aws
reviewed
Dec 18, 2025
wty-Bryant
force-pushed
the
feat-tmv2-audit
branch
from
2bbe6ef to
8c6ee20
Compare
Madrigal
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update remaining features to transfer manager v2 according to latest SEP specification: