Feat S3 Transfer Manager v2 GetObject/DownloadObject #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* recommit transfer manager v2 files * change pool to store slice pointer * add integ test for putobject * update go mod * minor changes for v0.1.0 * update tags * update tags * update integ test dependency version * change err var name * update go mod * change input/output type comment * minor change --------- Co-authored-by: Tianyi Wang <[email protected]> rebase from main rebase branch from main
move transfer manager v2 integration tests to within module move putobject integ test to transfer manager module
add getobject integ test
Madrigal
reviewed
Feb 3, 2025
| @@ -20,6 +20,8 @@ const defaultMultipartUploadThreshold = 1024 * 1024 * 16 | |||
| // using PutObject(). | |||
| const defaultTransferConcurrency = 5 | |||
|
|
|||
| const defaultPartBodyMaxRetries = 3 | |||
There was a problem hiding this comment.
is this copied over from existing implementation?
There was a problem hiding this comment.
yes, the latest SEP doesn't have such retry limitation in detail
| } | ||
|
|
||
| // GetObjectInput represents a request to the GetObject() or DownloadObject() call. It contains common fields | ||
| // of s3 GetObject input |
There was a problem hiding this comment.
this seems incomplete, of this and what else?
There was a problem hiding this comment.
Nothing else, GetObjectInput is the only s3 client input used here
| for _, opt := range opts { | ||
| opt(&i.options) | ||
| } | ||
| i.options.Concurrency = 1 |
There was a problem hiding this comment.
Why are we setting Concurrency to 1?
There was a problem hiding this comment.
GetObject here mimics s3.GetObject to get an object's chunks and write to output body in sequence, thus there should be only one goroutine to write chunks to output in order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement v2 s3 transfer manager's GetObject/DownloadObject api bound to single union client which mimics normal service client's initialization and api call. User could now download object sequentially with GetObject or asynchronously with DownloadObject.
Test: passed unit test for GetObject and DownloadObject, passed integration test of uploading object via s3 client and validating its content after downloading through v2 transfer manager.