Skip to content

Conversation

WillChilds-Klein
Copy link

@WillChilds-Klein WillChilds-Klein commented Oct 20, 2025

Issue #, if available:

Description of changes:

aws-crt-cpp v0.35.0 enables and prefers PQ by default for CRT HTTP clients.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
    • [childw] dependency version bump
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
    • [childw] not introduced by this PR, but I did notice that default-configured SDK requests used TLSv1.2 on MacOS and TLSv1.3 on Linux. I'm not sure why that is the case, but one implication is that MacOS builds won't have PQ TLS by default because PQ TLS is only available in TLSv1.3
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review October 20, 2025 17:59
@sbiscigl
Copy link
Contributor

im onboard with updating the version of the CRT but looks like you have a merge conflict, created a PR that doesnt have a merge conflict #3588. Will merge that one if there is no objection from your end

@sbiscigl
Copy link
Contributor

closing in favor of #3588 that didnt have merge conflicts

@sbiscigl sbiscigl closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants