Repository navigation
feat: package local MicrovmImage code artifacts - #9346
Open
proton0210 wants to merge 3 commits into
Open
proton0210 wants to merge 3 commits into
proton0210 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Closes #9283.
Why is this change necessary?
Local
AWS::Serverless::MicrovmImage.CodeUripaths are currently left unchanged by packaging. Moving the template duringsam buildalso leaves relative paths pointing at the wrong directory.How does it address the issue?
MicrovmImage.CodeUrias a local artifact and add a ZIP exporter using the existing S3 uploader/content hash. Directories are zipped; existing ZIPs are uploaded unchanged. S3 URIs and intrinsic references remain unchanged.CodeUriis missing.MicroVM Dockerfiles are built by the service, not Lambda runtime builders.
sam buildpreserves a reference to the original context, which must remain available until packaging. No new.samignore/.dockerignorebehavior is introduced. This is separate from WebFunction PR #9340.What side effects does this change have?
MicroVM code is recognized by the shared artifact detection/relocation/cleanup machinery, including existing
sam deleteretention behavior. No dependencies, IAM/bucket policies, or service-side image build behavior change. Usage and limitations are documented indocs/microvm-image-packaging.md.Testing
Three audit passes covered scope/build semantics, packaging safety/compatibility, and final regression/static checks.
make prpassed: schema generation, repository-wide Black/Ruff/mypy, 9,440 unit tests, 25 skipped, 31 subtests; 94.15% coverage.778292fand pass with this change.Mandatory Checklist
make prpassesmake update-reproducible-reqsif dependencies were changed (no dependency changes)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.