Skip to content

Change validation of automatic backup retention days of FSx Lustre to 90 #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanwen-cluster merged 2 commits into from
Jun 18, 2026
+2 −2
Merged

Change validation of automatic backup retention days of FSx Lustre to 90 #7405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a32243
Change validation of automatic backup retention days of FSx Lustre to 90
hanwen-cluster May 18, 2026
edbdcf7
Merge branch 'develop' into developmay22
hanwen-cluster Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/src/pcluster/schemas/cluster_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ class FsxLustreSettingsSchema(BaseSchema):
metadata={"update_policy": UpdatePolicy.SUPPORTED},
)
automatic_backup_retention_days = fields.Int(
validate=validate.Range(min=0, max=35), metadata={"update_policy": UpdatePolicy.SUPPORTED}
validate=validate.Range(min=0, max=90), metadata={"update_policy": UpdatePolicy.SUPPORTED}
)
copy_tags_to_backups = fields.Bool(metadata={"update_policy": UpdatePolicy.UNSUPPORTED})
daily_automatic_backup_start_time = fields.Str(
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/pcluster/schemas/test_schema_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def test_efs_throughput_mode_provisioned_throughput_validator(section_dict, expe
({"AutomaticBackupRetentionDays": ""}, "Not a valid integer"),
({"AutomaticBackupRetentionDays": 0}, None),
({"AutomaticBackupRetentionDays": 35}, None),
({"AutomaticBackupRetentionDays": 36}, "Must be.*less than or equal to 35"),
({"AutomaticBackupRetentionDays": 91}, "Must be.*less than or equal to 90"),
({"CopyTagsToBackups": ""}, "Not a valid boolean"),
({"CopyTagsToBackups": "NONE"}, "Not a valid boolean"),
({"CopyTagsToBackups": True}, None),
Expand Down
Loading