Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from default password #306

Open
wants to merge 1 commit into
base: v2.6.3
Choose a base branch
from
Open

Conversation

mjsqu
Copy link

@mjsqu mjsqu commented Aug 15, 2023

Fixes #210, #300

Changes the dotenv file to remove quotes from the DEFAULT_PASSWORD value, which allows the password test to be used, rather than "test". This has been checked on v2.6.3 but could be retrospectively applied to previous versions if possible (issue #210 was raised regarding v2.4.3)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mjsqu
Copy link
Author

mjsqu commented Aug 16, 2023

To clarify this issue, the default password appears to be test in double-quotes. Removing the double quotes from the .env file means that the default admin user is setup with the password being simply test without the double quotes, as stated in the documentation.

Copy link
Contributor

@mayushko26 mayushko26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commit, LGTM.

Could you also make similar PR's for the other versions please?

@mayushko26
Copy link
Contributor

Thanks, one more for 2.7.2 if you could.

@mjsqu
Copy link
Author

mjsqu commented Dec 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default credentials not working on tag v2.4.3
2 participants