Skip to content

Conversation

@nhatnghiho
Copy link
Contributor

Issues:

Resolves P321757685

Description of changes:

Fix a scrutiny warning with an unchecked return value

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho requested a review from a team as a code owner October 28, 2025 16:19
justsmth
justsmth previously approved these changes Oct 28, 2025
Copy link
Contributor

@justsmth justsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better resolution would be to return the failure to the caller.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.52%. Comparing base (16c148a) to head (890c725).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
tool-openssl/test_util.cc 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   78.65%   78.52%   -0.14%     
==========================================
  Files         678      678              
  Lines      116334   115346     -988     
  Branches    16312    16330      +18     
==========================================
- Hits        91507    90578     -929     
+ Misses      24039    23973      -66     
- Partials      788      795       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants