Closed
Conversation
justsmth
force-pushed
the
support-zig-compiler
branch
from
250314f to
5a92779
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
- Coverage 77.96% 77.95% -0.02%
==========================================
Files 689 689
Lines 122505 122505
Branches 17094 17095 +1
==========================================
- Hits 95512 95496 -16
- Misses 26095 26112 +17
+ Partials 898 897 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
support-zig-compiler
branch
from
5a92779 to
78f8e25
Compare
justsmth
force-pushed
the
support-zig-compiler
branch
from
78f8e25 to
5ca231c
Compare
justsmth
force-pushed
the
support-zig-compiler
branch
from
aff75d5 to
a40f3ae
Compare
justsmth
force-pushed
the
support-zig-compiler
branch
from
a40f3ae to
d328634
Compare
Zig's LLD linker produces .pdata/.xdata (SEH unwind data) that is incompatible with the RtlVirtualUnwind-based unwind tester, causing STATUS_ACCESS_VIOLATION (0xc0000005) in ABITest.SanityCheck. Add a -no-unwind-tests flag to all_tests.go and use it for the Zig Windows CI targets. This follows the same pattern used for SDE builds.
justsmth
force-pushed
the
support-zig-compiler
branch
from
f11f16e to
aeb031a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.