Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BORINGSSL_FIPS_abort to AWS_LC_FIPS_failure which takes a message #2182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewhop
Copy link
Contributor

Description of changes:

In preparation for the callback change in #2162 this change updates all the place that could abort to pass a message to a new abort function that explains why it's about to abort.

Testing:

The existing test-break-kat.go will ensure all the KATs still fail as expected and the messages they print match.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner February 8, 2025 01:43
@andrewhop andrewhop changed the title Update BORINGSSL_FIPS_abort to AWS_LC_FIPS_failure which takes a message.y Update BORINGSSL_FIPS_abort to AWS_LC_FIPS_failure which takes a message Feb 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (41060fe) to head (440bc12).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/self_check/self_check.c 69.56% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2182      +/-   ##
==========================================
+ Coverage   78.98%   79.02%   +0.03%     
==========================================
  Files         611      612       +1     
  Lines      105878   106064     +186     
  Branches    14984    14994      +10     
==========================================
+ Hits        83633    83819     +186     
- Misses      21588    21592       +4     
+ Partials      657      653       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants