Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUTINICE fixes #2180

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

SCRUTINICE fixes #2180

wants to merge 6 commits into from

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Feb 7, 2025

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Scrutinice alerts for a null check and potential memory leak

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (7b39332) to head (0a16794).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/pqdsa/pqdsa.c 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
+ Coverage   78.96%   79.01%   +0.05%     
==========================================
  Files         611      612       +1     
  Lines      105878   106074     +196     
  Branches    14984    14994      +10     
==========================================
+ Hits        83602    83818     +216     
+ Misses      21624    21603      -21     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smittals2 smittals2 marked this pull request as ready for review February 8, 2025 00:29
@smittals2 smittals2 requested a review from a team as a code owner February 8, 2025 00:29
crypto/fipsmodule/pqdsa/pqdsa.c Outdated Show resolved Hide resolved
crypto/ml_dsa/ml_dsa_ref/sign.c Outdated Show resolved Hide resolved
@smittals2 smittals2 requested a review from andrewhop February 8, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants