Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install_shared_and_static test more robust #2179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smittals2
Copy link
Contributor

Issues:

P198393553

Description of changes:

Making the test more robust to prevent flaky behavior:

  1. Add more logging
  2. Use sync to force file state after delete operations
  3. use --fresh with CMAKE to prevent using any cache
  4. Turn off parallel CMAKE build

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (6c613fa) to head (66d3110).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
+ Coverage   78.95%   78.98%   +0.02%     
==========================================
  Files         611      611              
  Lines      105551   105878     +327     
  Branches    14950    14984      +34     
==========================================
+ Hits        83341    83630     +289     
- Misses      21558    21595      +37     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smittals2 smittals2 marked this pull request as ready for review February 8, 2025 00:30
@smittals2 smittals2 requested a review from a team as a code owner February 8, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants