Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DEPENDS from add_custom_command as CMake made the behavior clear #2178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewhop
Copy link
Contributor

Description of changes:

Instead of silently ignoring the parameter CMake now prints a warning and lets the command continue to work:

CMake Warning (dev) at crypto/CMakeLists.txt:654 (add_custom_command):
  The following keywords are not supported when using
  add_custom_command(TARGET): DEPENDS.

  Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
  Run "cmake --help-policy CMP0175" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

https://cmake.org/cmake/help/latest/policy/CMP0175.html

Testing:

Built locally after deleting the option and didn't see the error message.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner February 7, 2025 22:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (41060fe) to head (170a73d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2178   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files         611      611           
  Lines      105878   105878           
  Branches    14984    14984           
=======================================
  Hits        83633    83633           
- Misses      21588    21592    +4     
+ Partials      657      653    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants